What’s wrong with this statement?

James Lin — Thu, 17 Apr 2014 04:08:10 +0000

This morning I made a code change to log some stuff in a core package and created a pull request, the change was very simple:

from

self.execute_command(command, cwd=os.path.dirname(infile))

logger.debug(self.execute_command(command, cwd=os.path.dirname(infile)))

One of the team lead pointed out the statement has a problem, and it was a life saver, but I won’t tell you why just yet, see if you can spot it.

When to optimize?

James Lin — Wed, 29 Aug 2012 01:17:15 +0000

“We should forget about small efficiencies, say about 97% of the time: premature optimization is the root of all evil.”

— Donald Knuth